Anything wrong with my code?Thanks.

[Wwx95]

(defun c:sbb(/a b)
 ((setq a 10 b 5)
   (if (> a b)
     (progn (princ a)
(setq a (+ a 5) b (+ b 6))
   ((princ a)(princ))
   ((princ b)(princ))
)
   )
 )
 )

Edited June 13, 2016 by SLW210
Added Code Tags

[BIGAL]

Way to many brackets

[SLW210]

Please post in the proper forum, I moved your thread to the AutoLISP, Visual LISP & DCL Forum.

 

Please read the Code Posting Guidelines and edit your post to include the Code in Code Tags.

 

[NOPARSE]

Your Code Here

[/NOPARSE] =

 

Your Code Here

[Lee Mac]

(defun c:sbb ( / a b )
  ;( this isn't required
   (setq a 10 b 5)
   (if (> a b)
       (progn 
           (princ a)
           (setq a (+ a 5) b (+ b 6))
          ;( this isn't required
           (princ a)
          ;(princ) This can be replaced by one final (princ)
           this isn't required
          ;( this isn't required
           (princ b)
          ;(princ) This can be replaced by one final (princ)
           this isn't required
       ) ;; end progn
   ) ;; end if
   (princ) ;; This can replace the earlier (princ) expressions
   this isn't required
) ;; end defun

[BIGAL]

Thanks Lee I thought I would give time for Wwx95 to have a go first. Nice touch the ;;defun I often do this for ;if's etc so you can keep count and make sure closing brackets.

[Wwx95]

Thanks, I am new here, and I changed my code according to your code,is it like this?

 

(defun c:sbb (/ a b)
   (if (> a b)
       (progn 
           (princ a)
           (setq a (+ a 5) b (+ b 6))
       ) 
   )
) 

 

But how can I run it in CAD? Like this?

 

(setq a 10 b 5)
(sbb a b)

 

It doesn't work, and told me "error: no function definition: SBB"

[Lee Mac]

Thanks Lee I thought I would give time for Wwx95 to have a go first. Nice touch the ;;defun I often do this for ;if's etc so you can keep count and make sure closing brackets.

 

Thank you Al

 

But how can I run it in CAD? Like this?

(setq a 10 b 5)
(sbb a b)

It doesn't work, and told me "error: no function definition: SBB"

 

If you wish to evaluate the function with arguments, you will need to define it in the following way:

(defun sbb ( a b )
   (if (> a b)
       (progn
           (princ a)
           (setq a (+ a 5) b (+ b 6))
       )
   )
)